IBX-3035: [Twig] Allowed passing parameters to `ibexa render` function #674

vidarl · 2025-11-03T14:05:24Z

🎫 Issue	IBX-3035

Description:

When using render(controller('ibexa_content::viewAction')), you can send parameters to the controller which will be available in the template.

Example:

    <h2>render controller</h2>
    {{ render(controller('ibexa_content::viewAction', {
        'contentId': content.id,
        'viewType': 'line',
        'params':
            { 'my_param': 'custom_data', }
    })) }}

    <h2>render_esi controller</h2>
    {{ render_esi(controller('ibexa_content::viewAction', {
        'contentId': content.id,
        'viewType': 'line',
        'params':
            { 'my_param': 'custom_data', }
    })) }}

This PR adds the same possibility when using ibexa_render() :

    <h2>direct</h2>
    {{ ibexa_render(content,
        {
            'viewType': 'line',
            'method': 'direct',
            'params': {
                'my_param': 'custom_data'
            }
        })
    }} <br/>

    {{ ibexa_render(location,
        {
            'viewType': 'line',
            'method': 'direct',
            'params': {
            'my_param': 'custom_data'
        }
        })
    }} <br/>

    <h2>inline</h2>
    {{ ibexa_render(content,
        {
            'viewType': 'line',
            'method': 'inline',
            'params': {
                'my_param': 'custom_data'
            }
        })
    }} <br/>

    {{ ibexa_render(location,
        {
            'viewType': 'line',
            'method': 'inline',
            'params': {
                'my_param': 'custom_data'
            }
        })
    }} <br/>


    <h2>esi</h2>
    {{ ibexa_render(content,
        {
            'viewType': 'line',
            'method': 'esi',
            'params': {
                'my_param': 'custom_data'
            }
        })
    }} <br/>

    {{ ibexa_render(location,
        {
            'viewType': 'line',
            'method': 'esi',
            'params': {
                'my_param': 'custom_data'
            }
        })
    }} <br/>

For QA:

Documentation:

…ibexa_render Twig function

…d code

…usted PHPstand baseline

sonarqubecloud · 2025-11-04T15:08:35Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vidarl · 2025-11-04T15:12:23Z

tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php

+        );
+    }
+
+    public static function forwardOptionsToFragmentRenderer(MockObject $fragmentRendererMock, MockObject $valueObjectMock, string $renderStrategyClass): void


This abstractions is made to avoid cut&paste of code for similar test in RenderLocationStrategyTest

This abstractions is made to avoid cut&paste of code for similar test in RenderLocationStrategyTest

But does it have to be static?

alongosz · 2025-11-05T10:33:00Z

src/bundle/Core/Fragment/InlineFragmentRenderer.php

            if ($request->attributes->has('viewParametersString')) {
                $uri->attributes['viewParametersString'] = $request->attributes->get('viewParametersString');
            }
+            if ($options['params'] ?? false) {


Please refactor this so you don't rely on true-ish expression inside of the if statement. This works because of implicit cast which can lead to some bugs under some circumstances. What is the real condition making this usable? !is_empty && is_array?

alongosz · 2025-11-05T10:33:43Z

src/bundle/Core/Fragment/InlineFragmentRenderer.php

            }
+            if ($options['params'] ?? false) {
+                $uri->attributes['params'] = $options['params'];
+                unset($options['params']);


This effectively changes the behavior which we can do in 6.0 ATM.

alongosz · 2025-11-05T10:38:46Z

src/lib/MVC/Symfony/Templating/RenderContentStrategy.php

        $renderer = $this->getFragmentRenderer($options->get('method', $this->defaultRenderer));

-        return $renderer->render($controllerReference, $currentRequest)->getContent();
+        return $renderer->render($controllerReference, $currentRequest, $options->has('params') ? ['params' => $options->get('params')] : [])->getContent();


Readability: please split this into multiple lines.

Personally I'd just go with:

Suggested change

return $renderer->render($controllerReference, $currentRequest, $options->has('params') ? ['params' => $options->get('params')] : [])->getContent();

return $renderer->render($controllerReference, $currentRequest, ['params' => $options->get('params', [])])->getContent();

and would've taken this into the account when processing further, effectively making params always present, reducing cognitive complexity.
But no strong feelings here.

alongosz · 2025-11-05T10:41:34Z

tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php

+        );
+    }
+
+    public static function forwardOptionsToFragmentRenderer(MockObject $fragmentRendererMock, MockObject $valueObjectMock, string $renderStrategyClass): void


This abstractions is made to avoid cut&paste of code for similar test in RenderLocationStrategyTest

But does it have to be static?

alongosz · 2025-11-05T10:42:11Z

tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php

+        );
+    }
+
+    public static function forwardOptionsToFragmentRenderer(MockObject $fragmentRendererMock, MockObject $valueObjectMock, string $renderStrategyClass): void


Missing PHPDoc defining type intersection for MockObject arguments.

IBX-3035: As a developer, I want to pass extra atrributes when using …

c12ad87

…ibexa_render Twig function

github-actions bot assigned mikadamczyk, alongosz and tischsoic Nov 3, 2025

mnocon added the Doc needed The changes require some documentation label Nov 4, 2025

Added tests for IBX-3035

dc40058

vidarl force-pushed the IBX-3035_As_a_developer_I_want_to_pass_extra_atrributes_when_using_ibexa_render_Twig_function branch 2 times, most recently from 2e09071 to 1bb7be8 Compare November 4, 2025 14:09

vidarl added 3 commits November 4, 2025 16:05

fixup! Added tests for IBX-3035 - Fixed Sonar warning about duplicate…

a2ab75a

…d code

Changed $this->assert* to self::assert* in related tests

c28e4f9

fixup! Changed $this->assert* to self::assert* in related tests - Adj…

2a1ab1c

…usted PHPstand baseline

vidarl force-pushed the IBX-3035_As_a_developer_I_want_to_pass_extra_atrributes_when_using_ibexa_render_Twig_function branch from 1bb7be8 to 2a1ab1c Compare November 4, 2025 15:06

vidarl added the Ready for review label Nov 4, 2025

vidarl commented Nov 4, 2025

View reviewed changes

alongosz reviewed Nov 5, 2025

View reviewed changes

alongosz changed the title ~~IBX-3035 as a developer i want to pass extra atrributes when using ibexa render_twig() function~~ IBX-3035: [Twig] Allowed passing parameters to ibexa render function Nov 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

IBX-3035: [Twig] Allowed passing parameters to `ibexa render` function #674

IBX-3035: [Twig] Allowed passing parameters to `ibexa render` function #674

Uh oh!

vidarl commented Nov 3, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Nov 4, 2025

Uh oh!

vidarl Nov 4, 2025 •

edited

Loading

Uh oh!

alongosz Nov 5, 2025

Uh oh!

alongosz Nov 5, 2025

Uh oh!

alongosz Nov 5, 2025

Uh oh!

alongosz Nov 5, 2025

Uh oh!

alongosz Nov 5, 2025

Uh oh!

alongosz Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	return $renderer->render($controllerReference, $currentRequest, $options->has('params') ? ['params' => $options->get('params')] : [])->getContent();
	return $renderer->render($controllerReference, $currentRequest, ['params' => $options->get('params', [])])->getContent();

IBX-3035: [Twig] Allowed passing parameters to ibexa render function #674

Are you sure you want to change the base?

IBX-3035: [Twig] Allowed passing parameters to ibexa render function #674

Uh oh!

Conversation

vidarl commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

For QA:

Documentation:

Uh oh!

sonarqubecloud bot commented Nov 4, 2025

Quality Gate passed

Uh oh!

vidarl Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

alongosz Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

IBX-3035: [Twig] Allowed passing parameters to `ibexa render` function #674

IBX-3035: [Twig] Allowed passing parameters to `ibexa render` function #674

vidarl commented Nov 3, 2025 •

edited

Loading

vidarl Nov 4, 2025 •

edited

Loading